Dev/alonyeshurun/mirror 4.2.0 #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "Power BI retains a seven-day refresh history for each dataset, up to a maximum of sixty refreshes" to description and Refreshable definition. Review links: • [Capacities - Get Refreshables](https://review.docs.microsoft.com/en-us/rest/api/power-bi/capacities/get-refreshables?branch=tris-refreshables-window-review) • [Capacities - Get Refreshables For Capacity](https://review.docs.microsoft.com/en-us/rest/api/power-bi/capacities/get-refreshables-for-capacity?branch=tris-refreshables-window-review) • [Capacities - Get Refreshable For Capacity](https://review.docs.microsoft.com/en-us/rest/api/power-bi/capacities/get-refreshable-for-capacity?branch=tris-refreshables-window-review) • [Admin - Get Refreshables](https://review.docs.microsoft.com/en-us/rest/api/power-bi/admin/get-refreshables?branch=tris-refreshables-window-review) • [Admin - Get Refreshables For Capacity](https://review.docs.microsoft.com/en-us/rest/api/power-bi/admin/get-refreshables-for-capacity?branch=tris-refreshables-window-review) • [Admin - Get Refreshable For Capacity](https://review.docs.microsoft.com/en-us/rest/api/power-bi/admin/get-refreshable-for-capacity?branch=tris-refreshables-window-review) Branch: trisshores-update-definitions-10
Review branch: tris-example-casing An example of the casing fix is: "completed import example" -> "Completed import example" See https://review.docs.microsoft.com/en-us/rest/api/power-bi/imports/get-import-in-group?branch=tris-example-casing
Please review carefully. This PR fixes what appears to be inadvertent trailing space in 19 swagger field names. One C# API file is affected by this fix.
Add workspaceId in AdminApp
- Replace "artifact" references in summary, descriptions, and definitions. - Make "datasource" two separate words. - Standardize "My workspace" formatting. - Use "OAuth 2.0" instead of "OAuth2", unless describing the parameter value.
Add widelySharedArtifacts APIs Related work items: #719387
Remove Reports API preview messages from: - Reports - Update Datasources - Reports - Update Datasources In Group
Fix the principal type, as requested by Lir. Review link: https://review.docs.microsoft.com/en-us/rest/api/power-bi/pipelines/update-pipeline-user?branch=tris-principalfix-review
Updated PostDatasetUser to make it clear that both datasets which resides in my workspace or Folders are supported
- Remove obsolete content (WS collection related) - Change the description to be more general: not focused on embed only but REST APIs in general - Provide up-to date simple examples (Get Report and Datasets, Generate Embed Token V2, Get Reports as Admin).
…nfo) Remove preview status from these API: - WorkspaceInfo GetModifiedWorkspaces - WorkspaceInfo GetScanResult - WorkspaceInfo GetScanStatus - WorkspaceInfo PostWorkspaceInfo
Notes: - Descriptions for boolean variables should start with something like "Whether to return..." instead of "Returns...", because the latter assumes that the boolean value was set to `true`. - I suggest "fully enabled" over "properly enabled" because "properly" doesn't on its own help a user know which control to enable, whereas "fully enabled" implies that both tenant settings that control metadata scanning should be enabled. However, it's not my decision, so let me know if changes are needed. - I updated the provided link for [Enable tenant settings for metadata scanning](Enable tenant settings for metadata scanning) since it pointed to the wrong article section.
This PR ensures all preview API calls have consistent language. Preview API summaries will have this final sentence: "This is a preview API call." This PR is layered on top of [Remove preview status from Scanner APIs (WorkspaceInfo)](https://powerbi.visualstudio.com/Embedded/_git/PowerBI-CSharp/pullrequest/229238) to avoid merge conflicts when that PR is merged. **Please review that PR first.**
Standardize all user principal name (UPN) references. Please let me know whether your customers are expected to know what a UPN is. If that's the case, I'll replace all instances of "user principal name (UPN)" with "UPN".
- Capitalizes all the examples (this was previously done, new examples got added since) - 'Required scope’ to ‘Required Scope’
The state of Goals API at this moment. It has been tested by a set of tests written by @<Andrew Garbuzov> which operate on msit deployment.
…eteDashboardInGroup new API Related work items: #692111
Version Bump to 4.2
… dev/alonyeshurun/mirror_4.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
Question
please answer the following questions. put x inside [ ] (e.g. [x])
What inside?
Is pull request totally generated from swagger file?
Backward compatibility break?
Learn more about backward compatibility.