Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chrome Browser Options #1384

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Add Chrome Browser Options #1384

wants to merge 8 commits into from

Conversation

AngelRodriguez8008
Copy link
Contributor

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (updates to documentation, formatting, etc.)

Description

Issue #1382 -> Add Option ExtraChromeArguments
Isuue #958 -> Add Option TimeFactor
If not use incognito mode, create a Temporal Chrome Profile in to avoid ask for login every time

Issues addressed

Add Chrome Browser Options, small changes, fix 2 Issues. Speed the tests execution.

All submissions:

  • My code follows the code style of this project.
  • Do existing samples that are effected by this change still run?
  • I have added samples for new functionality.
  • I raise detailed error messages when possible.
  • My code does not rely on labels that have the option to be hidden.

Which browsers was this tested on?

  • Chrome
  • Firefox
  • IE
  • Edge

@ManiMunna458
Copy link

@AngelRodriguez8008 May I know when this code changes are available ?

@AngelRodriguez8008
Copy link
Contributor Author

AngelRodriguez8008 commented Sep 25, 2023 •
edited

@ManiMunna458
Merging is blocked
Merging can be performed automatically with 1 approving review.

@chandramohand
Copy link

Hi, Any update regarding this PR?
Thanks,
Chandra.

AngelRodriguez8008
AngelRodriguez8008 commented Dec 18, 2023
View reviewed changes
Copy link
Contributor Author

@AngelRodriguez8008 AngelRodriguez8008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Shakevg
Shakevg approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@Shakevg Shakevg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Shakevg
Copy link
Contributor

Shakevg commented Mar 29, 2024 •
edited

TYLEROL dtu11
Could you please look and approve this request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shakevg Shakevg Shakevg approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AngelRodriguez8008 @ManiMunna458 @chandramohand @Shakevg