Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] support op builder from intel_extension_for_pytorch kernel path #5425

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

YizhouZ
Copy link
Contributor

@YizhouZ YizhouZ commented Apr 17, 2024

#Motivation
From our next release, xpu DeepSpeed related kernels would be put into intel_extension_for_pytorch. This PR is to add new op builders and use kernel path from intel_extension_for_pytorch. More ops like MOE and WOQ will be added.

@YizhouZ YizhouZ marked this pull request as ready for review May 7, 2024 13:29
@YizhouZ YizhouZ requested a review from mrwyattii as a code owner May 7, 2024 13:29
@YizhouZ
Copy link
Contributor Author

YizhouZ commented May 9, 2024

@loadams @mrwyattii Hi, could you help to trigger a CI for this PR? thanks!

@loadams
Copy link
Contributor

loadams commented May 9, 2024

@loadams @mrwyattii Hi, could you help to trigger a CI for this PR? thanks!

Done @YizhouZ - could you run the pre-commit formatter to pass the formatting check? Thanks

@YizhouZ
Copy link
Contributor Author

YizhouZ commented May 13, 2024

@loadams @mrwyattii Hi, could you help to trigger a CI for this PR? thanks!

Done @YizhouZ - could you run the pre-commit formatter to pass the formatting check? Thanks

Fixed! Could you run it again? Thanks.

@tjruwase tjruwase requested review from duli2012 and tjruwase and removed request for mrwyattii May 13, 2024 09:51
return None
def create_op_builder(self, class_name):
builder_class = self.get_op_builder(class_name)
return None if builder_class is None else builder_class()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builder_class could return NotImplementedBuilder or None. It's error prone to check between the two.

@YizhouZ YizhouZ requested a review from awan-10 as a code owner May 14, 2024 07:23
@YizhouZ
Copy link
Contributor Author

YizhouZ commented May 22, 2024

@tjruwase @loadams It seems nv-torch-latest-v100 / unit-tests tests failed somehow in today's merging commit. I did not see any error msg in log, is it something related to CI server?

@loadams
Copy link
Contributor

loadams commented May 22, 2024

@tjruwase @loadams It seems nv-torch-latest-v100 / unit-tests tests failed somehow in today's merging commit. I did not see any error msg in log, is it something related to CI server?

@YizhouZ - this looks to be a transient error on the CI nodes, it should be fixed now.

@YizhouZ
Copy link
Contributor Author

YizhouZ commented May 23, 2024

@tjruwase @loadams It seems nv-torch-latest-v100 / unit-tests tests failed somehow in today's merging commit. I did not see any error msg in log, is it something related to CI server?

@YizhouZ - this looks to be a transient error on the CI nodes, it should be fixed now.

thanks! could you help to trigger CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants