Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'bp uint64' #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ReneNyffenegger
Copy link
Contributor

Reduce the number of parameter-sets in Set-DbgBreakpoint to remove
ambuigity when trying to resolve
Set-DbgBreakpoint
such as
Set-DbgBreakpoint $exentry

Reduce the number of parameter-sets in Set-DbgBreakpoint to remove
ambuigity when trying to resolve
   Set-DbgBreakpoint <UInt64-addr>
such as
   Set-DbgBreakpoint $exentry
@ReneNyffenegger
Copy link
Contributor Author

Dan, I created this pull request because I need to be able to break on an exe's entry point:

bp $exentry

With this pull request, I seem to be able to do that now. Unfortunately, I am not sure if it breaks other use cases of the bp command. In particular, there is no differentiation anymore between choosing between -Command and -DbgEngCommand as I didn't find a way to allow for UInt64 and all parameter sets.

@jazzdelightsme
Copy link
Member

Sorry it has taken me so long to get to this. Thanks for the report! As you note, your change makes it possible to pass both -Command and -DbgEngCommand, which wouldn't make sense. We could check at runtime... but I'd prefer to have this enforced by the parameter sets (even though param sets are kind of a pain to get right). I have an idea how to fix this... see #100


In reply to: 808753035 [](ancestors = 808753035)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants