Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

minor changes: #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

minor changes: #18

wants to merge 2 commits into from

Conversation

abjinugu
Copy link

  1. Added one more parameter in case of different paths for data and logs
  2. Checking if the path is of linux machine when SQL Server installed on Linux

@abjinugu
minor changes:
aa4506e 
1. Added one more parameter in case of different paths for data and logs
2. Checking if the path is of linux machine when SQL Server installed on Linux
@msftclas
Copy link

msftclas commented Apr 17, 2018 •
edited

CLA assistant check
All CLA requirements met.

kevcunnane
kevcunnane suggested changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@kevcunnane kevcunnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! There are 2 things to update and then we can take this PR.

  1. As mentioned in my other comment, logdatalocation should be optional so that for most cases the existing sample "just works".
  2. Please verify that all tests in TestDbLocationModifiers.cs still pass, and ideally add/edit an existing test to cover the new scenario of specifying the log data location. The change as-is should cause that test to fail.

Samples/Contributors/DbLocationModifier.cs Outdated Show resolved Hide resolved
Samples/Contributors/DbLocationModifier.cs Outdated Show resolved Hide resolved
Samples/Contributors/DbLocationModifier.cs Outdated Show resolved Hide resolved
@abjinugu
1. Removed check for logdatalocation
5c23d9b 
2. Corrected indentation
@abjinugu
Copy link
Author

@kevcunnane , can you review this?

@o-o00o-o
Copy link

o-o00o-o commented Dec 3, 2020

@kevcunnane is this still being maintained?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevcunnane kevcunnane kevcunnane requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abjinugu @msftclas @o-o00o-o @kevcunnane