Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use urllib to parse the URL for the host and port #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use urllib to parse the URL for the host and port #55

wants to merge 1 commit into from

Commits on Dec 5, 2020

  1. Use urllib to parse the URL for the host and port 

    Parse the received URL string with urllib.parse.urlparse() to extract the hostname and port number (instead of splitting the URL to extract the hostname and port).

parse_remote() previously split the host string with ":" to get the host and port number, but splitting may result in a list of 3 strings (e.g., 'ws://192.168.4.1:8266'  would become ['ws', '//192.168.4.1', '8266']. The code would crash because of the double forward slashes at the beginning of the host string.
    @DarioBianco
    DarioBianco committed Dec 5, 2020
    Configuration menu
    Copy the full SHA
    5a974e0 View commit details
    Browse the repository at this point in the history