Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ports/esp32: Add support for 2 new BPI boards. #8690

Closed
wants to merge 1 commit into from

Conversation

Wind-stormger
Copy link
Contributor

BPI-Leaf-S2 and BPI-Leaf-S3 boards.

BPI-Leaf-S2 board uses esp32-s2 chip.

BPI-Leaf-S3 board uses esp32-s3 chip.

Both of them have Type-C socket to chip‘s internal USB , battery connector that support charging , and a 4 pin I²C connector .

BPI-Leaf-S3 reserves a Quad SPI RAM pad for upgrade.

The board.json image added in: micropython/micropython-media#15

Vendor: Banana Pi

@Wind-stormger
Copy link
Contributor Author

@dpgeorge

Please , how to remove the email address mentioned in check commit message formatting?

error: commit cffc68d: Unwanted email address: xxxx

In this commit, I have fixed the other issues in #8532 , but I have no ideas and solutions for the above issues.

@Wind-stormger
Copy link
Contributor Author

I have found a solution to the problem.

I should not set the email account associated with my github account to noreply, I should uncheck Keep my email addresses private.

@Wind-stormger Wind-stormger force-pushed the BPI_boards_PR branch 3 times, most recently from d877522 to 8fbfb0b Compare May 23, 2022 09:24
#define MICROPY_HW_BOARD_NAME "BPI-Leaf-S3"
#define MICROPY_HW_MCU_NAME "ESP32-S3"

#define MICROPY_PY_BLUETOOTH (0)
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to disable Bluetooth?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.

Just because the esp32s2 boards disable Bluetooth.
So I used the configurations of esp32s2 in the early stage.

I should correct some configurations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a force-pushed,make commits clean,and fix ‘Check commit message formatting ’ , now All checks have passed.

@Wind-stormger Wind-stormger force-pushed the BPI_boards_PR branch 2 times, most recently from 8371942 to da6b168 Compare August 3, 2022 07:07
@Wind-stormger
Copy link
Contributor Author

I have tested firmware compiled with micropython v1.19.1 and esp-idf v4.4 , both on 2 new BPI boards.

Everything looks good.

@mattytrentini
Copy link
Sponsor Contributor

I've tested against a Banana Pi Leaf S3 (I don't have the S2 boards, sorry), and the build looks good! Built with Espressif's IDF Docker Image (v4.4 IDF):

❯ docker run -ti --rm -v $(pwd):/code -w /code espressif/idf:release-v4.4 bash -c "make -C mpy-cross && make -C ports/esp32 submodules all BOARD=BPI_LEAF_S3"

Board appears to have 6MB free flash in the filesystem at boot, which seems correct.

My only suggestion is that I think a short, custom deploy.md should be created that a) linked to the BPI-Leaf-S3 wiki page and, more importantly, b) explains that the board needs to be put into 'bootloader' mode before upgrading (hold BOOT, press RESET, release BOOT).

@Wind-stormger
Copy link
Contributor Author

Thanks for your test and suggestion. @mattytrentini

deploy.md has been created.

The button name uses the bold format of Markdown, I don't know if it can be applied correctly in micropython.org.

The esptool command is changed to python -m esptool to expand the multi-platform applicability.

The BPI-Leaf-S3 wiki page has been added into board.json, looks like everyone does it.

tannewt added a commit to tannewt/circuitpython that referenced this pull request Dec 6, 2023
This changes storage.mount() to require that a mount point exist
on the parent file system.

A bug in background tasks is also fixed where the function
parameter is cleared on pending callbacks during "reset".

Disk usage is shown on the directory listing and changes based on
the mounted file system. Writable is also loaded per-directory.

Fixes micropython#8108. Fixes micropython#8690. Fixes micropython#8107.
tannewt added a commit to tannewt/circuitpython that referenced this pull request Dec 6, 2023
This changes storage.mount() to require that a mount point exist
on the parent file system.

A bug in background tasks is also fixed where the function
parameter is cleared on pending callbacks during "reset".

Disk usage is shown on the directory listing and changes based on
the mounted file system. Writable is also loaded per-directory.

Fixes micropython#8108. Fixes micropython#8690. Fixes micropython#8107.
tannewt added a commit to tannewt/circuitpython that referenced this pull request Jan 16, 2024
This changes storage.mount() to require that a mount point exist
on the parent file system.

A bug in background tasks is also fixed where the function
parameter is cleared on pending callbacks during "reset".

Disk usage is shown on the directory listing and changes based on
the mounted file system. Writable is also loaded per-directory.

Fixes micropython#8108. Fixes micropython#8690. Fixes micropython#8107.
tannewt added a commit to tannewt/circuitpython that referenced this pull request Jan 18, 2024
This changes storage.mount() to require that a mount point exist
on the parent file system.

A bug in background tasks is also fixed where the function
parameter is cleared on pending callbacks during "reset".

Disk usage is shown on the directory listing and changes based on
the mounted file system. Writable is also loaded per-directory.

Fixes micropython#8108. Fixes micropython#8690. Fixes micropython#8107.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants