extmod/network_nina: Fix the AP security mode constants. #14372
+5
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at the Nina firmware recently when I noticed that the command opcode
0x19
actually starts the AP in WPA/WPA2 mode. This has been long misunderstood because its handler was calledsetApPassPhrase
implying that it's WEP. Even though a function exists in the firmware that attempts to set up an AP with WEP, it seems that this mode is not supported for AP.I've verified this and the AP is using WPA/WPA2:
> nmcli dev wifi BSSID SSID MODE CHAN RATE SIGNAL BARS SECURITY 84:CC:A8:30:4C:51 NINA Infra 1 135 Mbit/s 100 ▂▄▆█ WPA1 WPA2
There are no functional changes in this PR, it just fixes the constants names and removes the useless sanity checks for
WEP
.