Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wiznet5k: Properly enable socket buffers for W5100(S). #14222

Conversation

greezybacon
Copy link
Contributor

The W5100 and W5100S only have 4 available sockets and 16kB of socket buffer. Allocating 16kB to either the receive or transmit buffer of a single socket is not allowed, so the current setup does not change the allocation for socket 0 from the reset default. ctlwizchip is returning -1 to indicate the error, but the response isn't being inspected and probably doesn't need to be.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (63c30a2) to head (36ca2bf).

❗ Current head 36ca2bf differs from pull request most recent head 8762fe8. Consider uploading reports for the commit 8762fe8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14222      +/-   ##
==========================================
- Coverage   98.39%   98.39%   -0.01%     
==========================================
  Files         161      161              
  Lines       21204    21200       -4     
==========================================
- Hits        20864    20860       -4     
  Misses        340      340              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 1, 2024

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@greezybacon greezybacon force-pushed the fix/wiznet5k-w5100-lwip-buffer-alloc branch from 7b2dcde to 36ca2bf Compare April 1, 2024 15:30
@dpgeorge dpgeorge added this to the release-1.23.0 milestone Apr 19, 2024
The W5100 and W5100S only have 4 available sockets and 16kB of socket
buffer.  Allocating 16kB to either the receive or transmit buffer of a
single socket is not allowed, so the current setup does not change the
allocation for socket 0 from the reset default.  ctlwizchip is returning -1
to indicate the error, but the response isn't being inspected and probably
doesn't need to be.

Signed-off-by: Jared Hancock <jared@greezybacon.me>
@dpgeorge dpgeorge force-pushed the fix/wiznet5k-w5100-lwip-buffer-alloc branch from 36ca2bf to 8762fe8 Compare May 7, 2024 07:43
@dpgeorge dpgeorge merged commit 8762fe8 into micropython:master May 7, 2024
58 checks passed
@dpgeorge
Copy link
Member

dpgeorge commented May 7, 2024

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants