Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiohttp_ws: convert Sec-WebSocket-Key from bytes to str #849

Closed
wants to merge 1 commit into from

Conversation

iot49
Copy link
Sponsor

@iot49 iot49 commented Apr 17, 2024

Without the fix, the client submits a header formatted as bytes:

Sec-WebSocket-Key     b'aaaaaaaaaaaaa'

resulting in the server rejecting the connection (I use the python websocket module in the server for checking). This PR decodes the key, and thus correctly formats the header:

Sec-WebSocket-Key     aaaaaaaaaaaaa

@Carglglz
Copy link
Contributor

Carglglz commented Apr 17, 2024

I think this is the same as #846

@iot49
Copy link
Sponsor Author

iot49 commented Apr 17, 2024 via email

@dpgeorge
Copy link
Member

Thanks for the patch, but I'll close this in favour of #846.

@dpgeorge dpgeorge closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants