Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micropython/mip/mip/__init__.py: Implement install from gitlab. #816

Closed
wants to merge 1 commit into from

Conversation

OlivierLenoir
Copy link
Contributor

Modify _rewrite_url() to allow mip install from gitlab: repository.

Signed-off-by: Olivier Lenoir olivier.len02@gmail.com

Modify _rewrite_url() to allow mip install from `gitlab:` repository.

Signed-off-by: Olivier Lenoir <olivier.len02@gmail.com>
@OlivierLenoir
Copy link
Contributor Author

OlivierLenoir commented Mar 1, 2024

Both pull requests are link to the same implementation of mip install from GitLab.

Signed-off-by: Olivier Lenoir olivier.len02@gmail.com


#816

Modify _rewrite_url() to allow mip install from gitlab: repository.

Signed-off-by: Olivier Lenoir olivier.len02@gmail.com


micropython/micropython#13791

mpremote: Implement mip install from GitLab.

tools/mpremote/README.md: Add mip install gitlab:org/repo@branch.
Add example mpremote mip install gitlab:org/repo@branch.

tools/mpremote/mpremote/mip.py: Implement install from GitLab.
Modify _rewrite_url() to allow mip install from gitlab: repository.

mpremote/mpremote/main.py: Add gitlab:org/repo, gitlab:org/repo@branch.
Modify argparse_mip() for gitlab:org/repo, gitlab:org/repo@branch.

docs/reference/packages.rst: Mip install from GitLab.
Describe how to mip install from GitLab.

docs/reference/mpremote.rst: Install package from GitLab.
Install the package from the specified branch at org/repo on GitLab.

Signed-off-by: Olivier Lenoir olivier.len02@gmail.com

@OlivierLenoir
Copy link
Contributor Author

@jimmo I think this PR is right.
What's the next step, if any?

@dpgeorge
Copy link
Member

Thanks for the contribution! This looks good, and is now merged.

@dpgeorge
Copy link
Member

Rebased and merged in 57cbc34

@dpgeorge dpgeorge closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants