webrepl: Changes for more webrepl features while making it smaller. #814
+85
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixdoerre
force-pushed
the
webreplv2
branch
2 times, most recently
from
e100da0
to
5aab2d1
Compare
|
@felixdoerre this could be a good opportunity |
This change: - Moves the password checking to python - Removes the special file transfer protocol - Moves the REPL data to websocket binary packages Signed-off-by: Felix Dörre <felix@dogcraft.de>
Signed-off-by: Felix Dörre <felix@dogcraft.de>
|
I've pushed a few adjustments and an (optional) bonus commit to allow specifying an ssl context. |
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change:
mpremoteto support webrepl just like a serial port)The change should be compatible with the current micropython version, however a new webrepl client needs to be deployed under https://micropython.org/webrepl/
Currently, to help you testing, I've adjusted the default URL to https://felix.dogcraft.de/webrepl/, where I host the corresponding draft "new" webrepl client. I've pushed the modified js code here, if you want to take a look: https://github.com/felixdoerre/webreplv2. I'm not completely sure, if I should open a PR in https://github.com/micropython/webrepl, as this seems to be the authoritative source of the client, but the repo seems to be abandoned for some time now.
The new webrepl client currently features (See also #13540):
mpremote.mount-feature frommpremotethat works with the same injected code. It allows mounting files from the browser's local storage (which can host some python scripts that one wants to bring for debugging), or from a local folder, that is drag-and-dropped into the webrepl (read-only), this is useful for rapid development/testing.Currently the "mount" feature has to be activated "manually" (by calling
hookme()from the developer tools, and then executing__mount()in the repl manually). Also the UI for the file browser might not be super intuitive yet (the + for upload and mounting a local folder might be too small and not clear enough). So I'm hoping for UI improvement suggestions.If you want, I can split the
mountand themipimplementation into separate PRs, but the file-browser and this PR are dependent on each other.With this change the
_webreplmodule from micropython is not needed anymore and can be removed.