Use new binutils gdb #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Espressif has switched from the binutils-esp32ulp repo (the original fork of binutils to support their microcontrollers) to their new repo binutils-gdb. (see espressif/esp-idf@a9bd454) The ESP-IDF also uses the esp32ulp assembler/linker from the new repo now. The main difference is that this is now the officially maintained implementation. The other difference is that there are now not different binaries for each esp32 variant, but one set of binaries. To select which esp32 variant to target, the esp32ulp-elf-as binary now accepts the --mcpu argument, for example --mcpu=esp32s2. The default is still the original esp32, so omitting the argument means one effected selected --mcpu=esp32. Note: Because Espressif provides pre-built binaries we are no longer building esp32ulp, but simply downloading the binaries and using those.
The examples from the testsuite are the same as in the previous binutils-esp32ulp repo from Espressif. But since the old repo will no longer be maintained, we switch to the new one. Currently all development happens on the esp32ulp-elf-2.35 branch and master does not (yet?) contain any files related to the Espressif-adapted assembler/linker. So we use this branch for now. Given that the branch name includes what appears to be a version number, it could mean Espressif might switch to a different branch down the line. We should pay attention to this and can then choose to switch to that branch too.
When using binutils-gdb (esp32ulp) to generate the "reference binary", which we compare against, pass --mcpu=esp32 to select the original ESP32 variant. While this is the default target of esp32-ulp-as, adding this argument makes the choice explicit and shows how to select a variant, for when we add support the ESP32-S2 or ESP32-S3 (both use --mcpu=esp32s2 because their ULPs have the same binary format).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a precursor step to adding support for the ULP-FSM of the ESP32-S2/S3.
This change changes where we get the esp32ulp assembler/linker from:
Espressif moved where they maintain the ULP assembler (see espressif/esp-idf@a9bd454), and this changes switches to the new esp32ulp assembler/linker, which is also what the latest ESP-IDF uses.
Since Espressif publishes a list of pre-built tools, which includes the esp32ulp assembler/linker, we now download the pre-built binaries, rather than building them ourselves.
The new esp32ulp assembler/linker only has a single set of binaries across all esp32 variants, and esp32ulp-elf-as accepts the --mcpu argument to select the specific variant.
For now we explicitly choose --mcpu=esp32 (even though that is the default) in our existing tests, but when adding support for the S2 (and S3, which has the same binary format) we can simply specify --mcpu=esp32s2 in the tests that target the S2.