chore: fix webapp lint & run lint autofix #1166
Conversation
|
Temporary set severity to warning for:
steel need to fix lint errors for them |
|
Wowow... This is a big one! Most of the changes seem to be trivial, but some others can have unexpected side effects.... |
There was a problem hiding this comment.
This is a huge amount of work. Thank you.
However I'm not a frontend expert enough to judge just by reading code. I asked some questions about some changes that didn't look that safe... Could you please have a look at them and provide some more explanations? Thanks!
webapp/src/main/webapp/src/app/components/confirm-delete/confirm-delete.component.ts
Show resolved
Hide resolved
...n/webapp/src/app/components/day-invocations-bar-chart/day-invocations-bar-chart-component.ts
Show resolved
Hide resolved
| .on('mousemove', function() { return tooltip.style("top", ((<any>d3.event).pageY - 10) + "px").style("left", ((<any>d3.event).pageX + 10) + "px"); }) | ||
| .on('mouseout', function() { return tooltip.style("visibility", "hidden"); }); | ||
| .attr('width', function() { return x.rangeBand(); }) | ||
| .attr('height', function(d: { key: string; value: any; total: any }) { return height - y(d.total); }) |
There was a problem hiding this comment.
Is this the result of automatic linting? Have you checked that there is no side effect?
There was a problem hiding this comment.
Are you talking about dot notation vs bracket notation?
It is common to use dot notation when the property name is known, and use bracket notation when the property name is stored in a variable or the property name has special characters or spaces
webapp/src/main/webapp/src/app/components/edit-labels-dialog/edit-labels-dialog.component.html
Show resolved
Hide resolved
webapp/src/main/webapp/src/app/components/edit-labels-dialog/edit-labels-dialog.component.ts
Show resolved
Hide resolved
webapp/src/main/webapp/src/app/components/score-treemap/score-treemap.component.ts
Show resolved
Hide resolved
webapp/src/main/webapp/src/app/components/score-treemap/score-treemap.component.ts
Show resolved
Hide resolved
Signed-off-by: soGit <soroka.sergei@gmail.com>
|
@lbroudoux I've done a quick smoke (manual) test. I'll do a code review as well, and I'm checking your comments today |
Signed-off-by: soGit <soroka.sergei@gmail.com>
soGit
force-pushed
the
1.9.x-fix-lint-webapp
branch
from
1704ed9
to
9101336
Compare
|
Thank you very much for this and for taking the time to provide explanations! I still have a lot to learn regarding Angular/Typescript specifics 😉 |
Description
Related issue(s)
Resolve #1165