Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kafka consumer sasl support #1006

Open
wants to merge 2 commits into
base: 1.8.x
Choose a base branch
from

Conversation

Afanas10101111
Copy link
Contributor

Description

Add a simple SASL OAUTHBEARER support for Kafka consumers.

  • Add a path variable that defines a custom handler for the Kafka consumer.
  • Add a path variable that defines a consumer group.id property (there may be a restriction on the broker's side).

Related issue(s)

@Afanas10101111
Copy link
Contributor Author

Hey @lbroudoux !
I want to disscuss this idea with you.
This is the simplest way to support OAUTHBEARER for consumers.
On the plus side

  • we can use different handles on the fly.

On the minus side

  • it only supports OAUTHBEARER (but we can also add SASL_MECHANISM and SASL_JAAS_CONFIG as path variables).
  • users must know the fully qualified handler class name.

But we can take a different approach.
What if we use a path variable like configSecurityProtocol=SASL_SSL which tells the consumer that it should take the sasl options from the minion config (we'll have to inject the Config config)?
On the plus side

  • easier setup of consumer tasks for users.

On the minus side

  • only preconfigured handler class is supported.

And I have some concerns about path variable names, so I'm asking for your advice about the naming.

@Afanas10101111 Afanas10101111 changed the title feat: kafka login callback handler support feat: kafka consumer sasl support Nov 28, 2023
@Afanas10101111 Afanas10101111 changed the base branch from master to 1.8.x December 5, 2023 11:02
…onsumer for the oauthbearer mechanism

Signed-off-by: Afanas10101111 <68496260+afanas10101111@users.noreply.github.com>
Signed-off-by: Afanas10101111 <68496260+afanas10101111@users.noreply.github.com>
@Afanas10101111
Copy link
Contributor Author

Hi @lbroudoux !
I've added an implementation of another approach with a new commit. It looks to be more compatible with the producer's previous modification to support custom handler.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 30 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. Microcks is a Cloud Native Computing Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale State due to inactivity label Jan 10, 2024
@Afanas10101111
Copy link
Contributor Author

Hello @lbroudoux
Could you take a look at this PR please?

@lbroudoux
Copy link
Member

Yes sure. I was busy releasing the 1.8.1 last week. I'd like to tackle this one for the next iteration.

@github-actions github-actions bot removed the stale State due to inactivity label Jan 16, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 30 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. Microcks is a Cloud Native Computing Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale State due to inactivity label Feb 16, 2024
@lbroudoux lbroudoux added component/tests kind/enhancement keep-open Explicitily keep open and removed stale State due to inactivity labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants