Avoid resetting serial terminal when possible #1117
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview build will be at |
| )} | ||
| <Box | ||
| // Need to render this when not connected as we need it to maintain scrollback across disconnect/reconnect in some cases. | ||
| display={connected ? undefined : "none"} |
There was a problem hiding this comment.
Until this change, reset wasn't really what was resetting the terminal—we were also discarding it entirely.
Need to review for unexpected consequences here.
Follow up to ca1f325 This aims to avoid EVENT_RESET when its due to the workaround we have in place that disconnects background tabs.
microbit-matt-hillsdon
force-pushed
the
avoid-serial-reset
branch
from
8508eb6
to
5633bfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to ca1f325
This aims to avoid EVENT_RESET when its due to the workaround we have in place that disconnects background tabs.