Add support of Block and CodeBlock #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the variable substitution is only made for text. This updates pandoc-mustache to also substitute variables from Block and CodeBlock. Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
|
@anobli: This is a good idea! Thanks for submitting this PR. Would you be up for adding two tests verifying that pandoc-mustache successfully substitutes variables in Block and CodeBlock environments? You could add them as one or two Python scripts in |
anobli
force-pushed
the
master
branch
2 times, most recently
from
f28650e
to
72cd99d
Compare
This adds a new test to check that variable substitution is working correctly for Code or Codeblock. Note: The test is mostly a copy past of test_mustach_in_abstract. Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
|
Hi @michaelstepner , It seems that @anobli implemented the tests you've requested in 72cd99d Is there anything preventing from merging this PR? I would like to get rid of our internal fork we use at BayLibre. We have been using both patches for quite some time already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the variable substitution is only made for text.
This updates pandoc-mustache to also substitute variables in Block
and CodeBlock.
Signed-off-by: Alexandre Bailon abailon@baylibre.com