Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added darwin support #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

twhiston
Copy link

@twhiston twhiston commented Sep 18, 2017

Hi,

I've added some functions to your port to get it to compile on Darwin (OSX) systems. Mainly this just involved creating a few functions you get in Linux and changing a few printf's to use the right types. All of these changes are wrapped in an #ifdef which is only defined if __APPLE__ or __MACH__ are defined by the system. I also added an UNUSED macro which you can wrap unused vars in to deal with compiler errors.

The one 'annoying' change is that clang doesn't like -pthread in the linker flags, so i had to remove this for darwin builds. Rather than put the logic to deal with this in to every demo makefile i broke it out into an include and added this file to all the makefiles instead.

After doing these things build_all.sh works perfectly on osx and all the demo programs build and run.

@twhiston
Copy link
Author

@michaelbecker would love to get your thoughts on this PR. Thanks for all the great work on this repo!

@abeck70
Copy link

abeck70 commented Dec 23, 2017

@michaelbecker i would be keen to see os x support and can help test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants