Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid script execution if remote is a full HTML page #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cerdic
Copy link

@Cerdic Cerdic commented Nov 13, 2014

TODO : need improvement if script in body part of the page

TODO : need improvement if script in body part of the page
@michael-lynch
Copy link
Owner

Is this necessary? I haven't tested the plugin using a remote page that includes a script but I don't think it should matter, because the remoteTarget will limit the content to the specified element. Can anyone confirm this?

@Cerdic
Copy link
Author

Cerdic commented Dec 9, 2014

The problem is that setTime($('<div>').html(data) make all scripts tags of remote page data beeing executed.
My use case is indicating reading time of "next article", so the remote page is a full HTML page embeding jQuery as the current one. Thus jQuery is overriden with a new instance and this broke some scripts that had a kept some reference to jQuery or some if it's methods.

Copy link

@wilfreddekok wilfreddekok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a merge conflict?

oops, didn't read @Cerdic 's latest comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants