Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion. Remove unuseful panic #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gollariel
Copy link

@gollariel gollariel commented Apr 14, 2020

Usually:

  1. panic generate a lot of unuseful traces
  2. should be catch and logged additionally
  3. defer not make sense, cause it last line in the method

This PR fix that behavior

Remove unuseful panic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant