Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory Tweaks Tree sorting 1.16 #2380

Open
wants to merge 17 commits into
base: 1.16
Choose a base branch
from

Conversation

IMarvinTPA
Copy link
Contributor

I hope this makes it in, but I would understand if it does not. If not, can you help me understand how to make an API that would register a new comparator? I don't think the ENum IngredientSortStage makes adding new ones easy.

@Eric-01
Copy link
Contributor

Eric-01 commented Jun 6, 2021

Isn't Inventory Tweaks discontinued (especially in 1.13+)? Wouldn't it be better to reuse sorting rules from one of the modern and still maintained mods instead, such as: Inventory Profiles (IMO the best one as it has client-side sorting), Inventory Sorter (made by cpw), Inventory Tweaks Renewed, etc.?

@IMarvinTPA
Copy link
Contributor Author

I'm in the middle of adding the tree sorting feature to Inventory Tweaks Renewed, but I need to spend a fair bit of time with the network syncing code and have made no attempt yet at that. The reason I keep adding some form of Inventory Tweaks sorting to JEI is that it is the easiest way to find a display that shows "all the things" and test out the sorter, identify what's missing and add it to the file.

@mezz
Copy link
Owner

mezz commented Jun 10, 2021

This should definitely be an API call and not all included in here. I can help with this later.

@IMarvinTPA
Copy link
Contributor Author

@mezz Ok. I'll make a new pull request for just the sorting config bits. I think I'm almost done getting InventoryTweaksRenewed working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants