Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): wip #922

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(cli): wip #922

wants to merge 1 commit into from

Conversation

hughrawlinson
Copy link
Member

No description provided.

@@ -0,0 +1,50 @@
import {SampleBufferStream} from "../../src/cli/SampleBufferStream";

describe(SampleBufferStream, () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests were generated with GitHub Copilot, I have no idea what they do

@@ -0,0 +1,45 @@
import { Transform } from "stream";

export class SampleBufferStream<
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely don't use this - it will fail when the hop size is greater than the contents of the buffer.

return x in options;
}

const p = "a".slice(0);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is code testing the function above and should be deleted.

export function parseReceivedOptions(receivedOptions: {
[key: string]: unknown;
}): CliOptions {
switch (true) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this rather inscrutable block has me questioning the switch(true) pattern.

@@ -0,0 +1,16 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol tabs?????

@hughrawlinson hughrawlinson changed the base branch from master to main October 31, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant