v6 breaking changes #886
Draft
v6 breaking changes #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughrawlinson
force-pushed
the
v6
branch
3 times, most recently
from
8f316a7
to
10826db
Compare
hughrawlinson
force-pushed
the
v6
branch
3 times, most recently
from
124f881
to
2f81985
Compare
|
Here is a lil web page that visualizes the two new fluxes. |
A constant exists in the formula for converting between hz and the mel scale, which Meyda has had set to 1125. The mel-scale is not standardised, but it seems that the most popular formula comes from "Speech communication: human and machine" by Douglas O'Shaughnessy. That formula has the constant as 1127. The issue mentioned below was opened, and suggests that we converge on O'Shaughnessy's constant. This commit implements that change. BREAKING CHANGE: A change in how Meyda performs frequency to mel scale conversion will result in different mel-values between this and previous versions of Meyda. fix #458
…enance BREAKING CHANGE: remove nodes 10 and 13 fix #842
Also document the upper bound of flux as the square root of the length of the buffers, and if only one buffer is given, return 0
also minor corrections in spectral flux and tests for that re #1074
We have dropped support for node 12 and 15, and added support for node 18, in line with the node foundation support schedule. BREAKING CHANGE: Dropped support for node 12 and 15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging breaking changes to this branch for release together later.