refactor(export): remove manual window export #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooh the plot thickens - our bundler doesn't do window exports by default! I'll investigate and learn something new about bundling. No rush though. |
|
Glad we have the tests now! They'll be useful for #824 too. |
|
I've been trying this out in the Rollup branch and it looks like this is an issue in jsdom but not necessarily in browsers (it works fine in Firefox). I'll do some Googling and see if there's something about jsdom globalThis assignments that I don't understand. |
hughrawlinson
force-pushed
the
remove-manual-window-export
branch
from
df933f5
to
78cb9f5
Compare
We were manually putting the Meyda object on the window, if it existed. Our bundler does this for us, so we don't need to do it. This commit removes that line. fix #831
hughrawlinson
force-pushed
the
remove-manual-window-export
branch
from
78cb9f5
to
a254669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were manually putting the Meyda object on the window, if it existed. Our bundler does this for
us, so we don't need to do it. This commit removes that line.
fix #831