Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manual window export #831

Open
hughrawlinson opened this issue May 26, 2021 · 1 comment · May be fixed by #835
Open

Remove manual window export #831

hughrawlinson opened this issue May 26, 2021 · 1 comment · May be fixed by #835
Labels
good first issue

Comments

@hughrawlinson
Copy link
Member

hughrawlinson commented May 26, 2021 •
edited

Our build tools give us this for free. The relevant line is right at the bottom of src/main.js
hughrawlinson added a commit that referenced this issue May 27, 2021
@hughrawlinson
refactor(export): remove manual window export
7ba93e8 
We were manually putting the Meyda object on the window, if it existed. Our bundler does this for
us, so we don't need to do it. This commit removes that line.

fix #831
@hughrawlinson hughrawlinson linked a pull request May 27, 2021 that will close this issue
Open
@hughrawlinson
Copy link
Member Author

Don't bother with this until #824 lands!

hughrawlinson added a commit that referenced this issue May 30, 2021
@hughrawlinson
refactor(export): remove manual window export
78cb9f5 
We were manually putting the Meyda object on the window, if it existed. Our bundler does this for
us, so we don't need to do it. This commit removes that line.

fix #831
hughrawlinson added a commit that referenced this issue Jul 17, 2021
@hughrawlinson
refactor(export): remove manual window export
a254669 
We were manually putting the Meyda object on the window, if it existed. Our bundler does this for
us, so we don't need to do it. This commit removes that line.

fix #831
@t-moennich t-moennich mentioned this issue Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(export): remove manual window export meyda/meyda
chore(build): remove manual export
1 participant
@hughrawlinson