Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable (leaf-)Schema caching #870

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enable (leaf-)Schema caching #870

wants to merge 3 commits into from
+62 −10

Conversation

ikitommi
Copy link
Member

@ikitommi ikitommi commented Mar 14, 2023 •
edited

Leaf-schemas are usually created without properties or children. This MR introduces IntoSchema level caching. Schema instance cache is enabled if all of the following apply:

  • IntoSchema instance
  • which also support Cached
  • is instantiated without children, properties or options

Currently, this is enabled just for m/-simple-schemas, yielding 15% better performance on schema creation + smaller memory footprint (not tested)

@ikitommi ikitommi added enhancement New feature or request invalid This doesn't seem right labels Mar 14, 2023
@ikitommi
Copy link
Member Author

marked as invalid as not sure if this makes sense. More code, small benefits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
Metosin Open Source Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ikitommi