Minor musette updates #210
base: main
Are you sure you want to change the base?
Conversation
scrollbar-width: none; | ||
|
||
&::-webkit-scrollbar { | ||
display: none; | ||
} | ||
} | ||
|
||
.la-musette--rtl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would prefer if all new code has snapshot coverage... that's kind of the point! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but just have the 1 question about rtl vs row-reverse
scrollbar-width: none; | ||
|
||
&::-webkit-scrollbar { | ||
display: none; | ||
} | ||
} | ||
|
||
.la-musette--rtl { | ||
flex-direction: row-reverse; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does direction: rtl;
work here? If the musette gets embedded in some other component that's already rtl
we probably don't want to still row-reverse
do we ?
- ### [Storybook Development](#Storybook-Development) | ||
- ### [Webpack Build for Release And Production](#[Webpack-Build-for-Release-And-Production) | ||
- ### [Browsers We Support](#Browsers-We-Support) | ||
- [What is Marble?](#What-is-Marble) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the README improvements! i added a couple more
To work with new Marble v1.2.3 layout and fix a few small things in README