[vue-sass] Follow Symlinks for imports #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scss imports in imports are often broken as the paths there may be absolute to node_modules (at least in the case of @Material packages). To fix this, there is now a config option in package.json: vue.css.loaderOptions.sass.includePaths (array of Strings)
As vue-sass checked that files exists with fs.lstatSync().isFile(), files with an symlink in their path were not detected as existing. This fix now Checks if the path is an symlink. If so, then the symlink will be resolved and checked if the resolved path is an exising file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package vue-sass was unable to follow files via symbolic links and was therefore unable to import them via sass/scss import.
This is now fixed by especially looking for symlinks and resolving them first.
(Aparently i've done something wrong, so some changed code from PR-346 is also shown in the changed files. But this should not be a problem as this PR was merged)