Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-mounter on Meteor 1.3+ #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

diegonc
Copy link

@diegonc diegonc commented Jul 13, 2016

If 'require' is available, use it to gather the dependencies
needed to mount the React component that wraps our templates,
namely 'react' and 'react-mounter'.

This dependencies are not required in 'package.js' because of
the warnings in Meteor Guide[1].

In addition, 'kadira:react-layout' and 'react' atmosphere packages
are removed to avoid conflicts with NPM packages when 'flow-routing'
is used in a Meteor 1.3+ application.

Unfortunately this means that applications written for prior versions
of Meteor should now explicitly include them.

Fix #32

[1] https://guide.meteor.com/writing-atmosphere-packages.html#peer-npm-dependencies

If 'require' is available, use it to gather the dependencies
needed to mount the React component that wraps our templates,
namely 'react' and 'react-mounter'.

This dependencies are not required in 'package.js' because of
the warnings in Meteor Guide[1].

In addition, 'kadira:react-layout' and 'react' atmosphere packages
are removed to avoid conflicts with NPM packages when 'flow-routing'
is used in a Meteor 1.3+ application.

Unfortunately this means that applications written for prior versions
of Meteor should now explicitly include them.

[1] https://guide.meteor.com/writing-atmosphere-packages.html#peer-npm-dependencies
...instead of gwendall's blaze-to-react.
@hmontes
Copy link

hmontes commented Sep 2, 2016

Thank you!!! This works like a charm!!

You saved my life. @splendido Please apply this simple update to your package for React users

@vladbalan
Copy link

  • 👍

@yoonwaiyan yoonwaiyan mentioned this pull request Oct 17, 2016
@isAlmogK
Copy link

Is this package still alive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants