Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Error Message Strings #1102

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samuelvanderwaal
Copy link
Contributor

@samuelvanderwaal samuelvanderwaal commented May 19, 2023

Frees up 30k of binary space by removing all the hard-coded error message strings and extracting them to an external file. Clients that want to display the full message can download the file and look up the error message by hexcode.

It's possible this could break people's integration tests if they are relying on specific error messages instead of the message number or type so we need to do some analysis on that.

@samuelvanderwaal samuelvanderwaal requested a review from a team as a code owner May 19, 2023 23:16
@samuelvanderwaal samuelvanderwaal requested review from lorisleiva and danenbm and removed request for a team May 19, 2023 23:16
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5029052145.

@samuelvanderwaal samuelvanderwaal marked this pull request as draft May 19, 2023 23:25
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5029270571.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant