Itemviews basetreeview cleanup

[zas]

Summary

• This is a…
  • Bug fix
  • Feature addition
  • Refactoring
  • Minor / simple change (like a typo)
  • Other
• Describe this change in 1-2 sentences:

Problem

• JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

• Update Picard documentation (please include a reference to this PR)
• Other (please specify below)

[phw]

I noticed that the menu now breaks if there are no other versions other than the selected one. The previous implementation still showed the submenu, which I think works better.

Also if we limit the number of loaded results we should somehow still make sure that the list includes the currently selected release. It can happen that this is not the case if the total count exceeds the request limit and the current release is outside the returned result. Maybe we can inject the current release from already loaded release data?

I think the limit of 40 is still too much:

Maybe better use 20 only?

[zas]

I noticed that the menu now breaks if there are no other versions other than the selected one. The previous implementation still showed the submenu, which I think works better.

What do you mean by "it breaks"? It should be disabled (as there's no other versions).

Maybe we can inject the current release from already loaded release data?

Yes, that would be the best option, since we don't know if the currently selected will be or not in retrieved limited list of releases.
To be honest, I completely overlooked this point.

I think the limit of 40 is still too much:

This is why I added a default value, my idea is to add an option to make it configurable (using this default value), because it is very dependent on the graphical environment (size of fonts, screen resolution, etc.).

[zas]

@phw: I'll remove last commit from this PR, since it will require much more work and it's more than refactoring.
So please review up to 286bff9

[phw]

LGTM