MBS-13572 / MBS-13573: Don't break on more LiveNation and Ticketmaster links #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
changed the title
reosarevok
changed the title
yvanzo
approved these changes
May 15, 2024
I did not find links with _ nor - when implementing this, but clearly they exist. This expands the cleanup to support them.
Seems the original regex was too restrictive, since there is a second type of Ticketmaster links that can include any letters including lowercase (see example added to test). This just accepts any \w in the IDs since restricting further seems possibly problematic now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-13572 / MBS-13573
Problem
For LiveNation, I did not find links with
_nor-when implementing this originally, but clearly they exist, as the example in the ticket (now added to the test) shows. We were breaking these with the cleanup.For Ticketmaster, there seems to be a second, less common type of links that can use all uppercase and lowercase letters in the IDs, which again I had not found when implementing this and was being rejected by the cleanup.
Solution
Just accept
_and-on LiveNation identifiers, and allow all of\won Ticketmaster ones.Testing
Added the previously breaking example links to the automated tests.