Update React to 18.3.1 #3249
Merged
Update React to 18.3.1 #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the useless empty comments are no longer added as often as they used to be.
yvanzo
reviewed
May 15, 2024
mwiencek
approved these changes
May 17, 2024
Does the upgrade actually cause new warnings to be logged for us, or are you talking about simply removing the deprecated APIs from the Flow libdefs? |
|
The latter - no warnings I could see, but I didn't use everything - if warnings are logged to sentry then we know what to improve on though :) |
reosarevok
added a commit
that referenced
this pull request
May 17, 2024
* master: Update POT files using the production database MBS-13577 / MBS-13578: Release filtering for missing data (#3262) MBS-13589: Handle Operabase /o links (#3268) Convert /static/scripts/release templates to use Flow component syntax Convert /static/scripts/relationship-editor templates to use Flow component syntax Convert some more /static/scripts/ templates to use Flow component syntax Remove seemingly useless double export Convert /static/scripts/edit/components templates to use Flow component syntax Convert /static/scripts/common/components templates to use Flow component syntax Drop dead code in AddEntityDialog Drop unneeded instance typing in hydrate input Convert /components templates to use Flow component syntax Convert /components/list templates to use Flow component syntax Convert /components/Aliases templates to use Flow component syntax Convert /layout sidebar templates to use Flow component syntax Convert /layout templates to use Flow component syntax MBS-13585: Report for non-video recordings with video relationships (#3266) MBS-13581: Check "renamed into" in ArtistsThatMayBeGroups (#3265) Convert /edit/details templates to use Flow component syntax Convert /edit/details/historic templates to use Flow component syntax Convert /edit/component templates to use Flow component syntax Convert /edit templates to use Flow component syntax Update React to 18.3.1 (#3249) MBS-13263: Align release titles despite indicators (#3256) MBS-13588: Relationship phrase groups with pending edits are sometimes not highlighted Add `PendingEditsRoleT` to `RelatableEntityRoleT` Make `Entity::Artist::TO_JSON` consistent with `ArtistT` Use consistent chained method formatting Cache pending requests for `getOrFetchRecentItems` MBS-12741: Convert Create/Edit attribute admin pages to React Fix typo Limit `getReleaseGroupRecordings` to 5 attempts MBS-13558: Convert /report templates to use Flow component syntax MBS-13558: Convert /report/component templates to use Flow component syntax MBS-13573: Support a second format of Ticketmaster links MBS-13572: Support LiveNation links with _ and - MBS-13559: Don't reject dailysomething Bandcamp pages (#3255) Add context to newly added [removed] (#3246) Reuse same 'view list' string everywhere (#3247) Document that language packs must be installed Fix installing translations for beta/test websites admin/cron/hourly-sitemaps.sh: Dump FKs from READONLY Add missing scripts required by JSON dumps/sitemaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
18.2.0 fixed some false positive errors, maybe it will improve the issues with tons of Suspense hydration errors being logged on Sentry?
18.3.0 / .1 make no changes other than adding warnings for things that will be removed with v19, which is now in beta.
For now this just updates the package - I have not changed the types to remove the deprecated stuff with warnings since I guess we'll want to do that for 19.0.0?
Putting this up for CI and for general advice on what else if anything is needed, since recently we've only updated on major versions (which obviously require more work).