MBS-13217: Fix displaying cover art edits #3001
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two glitches were affecting the display of cover art edits. 1. When a release was merged, the release field was wrongly displayed as not existing anymore. 2. When a release was merged or deleted, the cover art field was wrongly claimed as not displayable (but for "Add cover art" edits). This patch loads two different releases instead, one for release link and the other for cover art image, and sets release MBID/GID if merged.
mwiencek
reviewed
Feb 2, 2024
| name => $self->data->{entity}{name}, | ||
| # Allow linking to release redirecting to still existing release. | ||
| $self->c->model('Release')->get_by_gid($self->data->{entity}{mbid}) ? ( |
There was a problem hiding this comment.
I remembered that the foreign_keys method also supports loading entities by MBID, IIRC. So I believe we can just replace the reference to $self->data->{entity}{id} in foreign_keys, and also in the $loaded_release assignment above, to point to the mbid property instead (unless I am missing something).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem MBS-13217
Two glitches were affecting the display of cover art edits.
Solution
This patch loads two different releases instead, one for release link and the other for cover art image, and sets release MBID/GID if merged.
Work in progress
ReorderCoverArttooNotes
Adding CI tests is a separate ticket: MBS-11490.