MBS-13201: Add ORCID to other databases whitelist and handle links #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds a basic cleanup and validation. As far as I can tell, only researchers (so, artists) get ORCIDs. Regex based on: https://support.orcid.org/hc/en-us/articles/360006897674-Structure-of-the-ORCID-Identifier
As per https://info.orcid.org/brand-guidelines/ they seem to prefer the logo + the ID itself, which we could do, but I don't think the ORCID logo is recognizable outside a pure academic context, so I chose to do logo + ORCID for now and hope they don't mind.
yvanzo
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-13201
Description
ORCID identifiers are given to researchers - this includes music researchers (like musicologists and some academically trained musicians) as well as musicians that also happen to be scientists for their day jobs.
As far as I can tell, only researchers (so, artists) get ORCIDs, so every other entity gets an ENTITY error.
The regex for the valid profile URLs is based on https://support.orcid.org/hc/en-us/articles/360006897674-Structure-of-the-ORCID-Identifier
For the sidebar, as per https://info.orcid.org/brand-guidelines/ they seem to prefer the logo + the ID itself, which we could do, but I don't think the ORCID logo is recognizable outside a pure academic context, so I chose to do logo + ORCID for now and hope they don't mind.
Testing
Manually plus added a test for the cleanup and another to make sure search links are rejected.