MBS-13361 (mirror): Upgrade to PostgreSQL 16 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It replaces and simplifies previous Postgres version upgrade scripts. The simplifications are due to not having additional scripts this time.
Since the container is specifically started with the command sleep
instead, the following error message is expected and harmless:
pg_ctl: could not send stop signal (PID: 1648): No such process
* Replace the pause of 5 seconds with a more robust check * Disable pager that caused the command to hang indefinitely
The container name assumed 4 years ago is no longer current, as `-` dash is now used by default instead of `_` underscore. Moreover, the project name can be customized in deployment, and thus it doesn’t necessarily match `musicbrainz-docker`. Using container ID instead is more robust, and still supported by Docker Compose v1.
Use the new instructions provided by `pg_upgrade`. Reference: https://www.postgresql.org/docs/14/release-14.html#id-1.11.6.17.5.12
Use the file `update_extensions.sql` provided by `pg_upgrade`.
2 tasks
mwiencek
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As final part of MBS-13361, this patch upgrades the version of PostgreSQL to 16.
It also updates the one-off script for upgrading the PostgreSQL database.
Similarly as for Postgres 12 upgrade four years ago, this script
admin/upgrade-to-postgres16has to be run.This pull request is targeting the branch
schema-change-2024-q2in order to avoid messing up new installations until the schema change is released.