Refactor Playlist class to functional component #2860
Merged
+390
−444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some routes we need to render a RouterProvider with a single custom route rather than the component itself, but we can't do that if there is already a BrowserRouter wrapper in renderWithProviders. Added an option to not add a router.
Removed the library in 3b608ab
It is required by react-tooltip, let's aim to move to V5 which drops uuid as a requirement https://react-tooltip.com/docs/upgrade-guide/changelog-v4-v5
12 tasks
…enbrainz-server into playlist-refactor
anshg1214
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring mooooore components.
Had to make some changes to renderWithProviders to allow rendering without a router, becuase this component uses useLoaderData which requires us to render a RouterProvider with a specific route rather than rendering the component we are testing directly.