New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LB-1366: Updated POST /grid/ endpoint #2717
base: master
Are you sure you want to change the base?
Conversation
1) The endpoint now accepts release_group_mbids array. 2) Capped the number of mbids to process in a request to 100.
Hello @07jasjeet! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-02-05 17:14:43 UTC |
How should I go about the tests?
|
|
||
release_mbids = list(r["release_mbids"]) | ||
|
||
# Get release_group_mbids |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to support having both release mbids and release group mbids. If release mbids are specified use them if not try for release group mbids.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then depending on which entity is being used, pass the correct value (release
or release-group
) to
entity="release", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Using both releases and release groups like this will break some links in the SVGs so instead we simplify a few things and only support release or release groups at a time but not both.
Problem
LB-1366
Action