Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB-1366: Updated POST /grid/ endpoint #2717

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

07jasjeet
Copy link
Contributor

Problem

LB-1366

Action

  1. The endpoint now accepts release_group_mbids array.
  2. Capped the number of mbids to process in a request to 100.

1) The endpoint now accepts release_group_mbids array.
2) Capped the number of mbids to process in a request to 100.
@pep8speaks
Copy link

pep8speaks commented Jan 17, 2024

Hello @07jasjeet! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 228:1: W293 blank line contains whitespace

Line 67:131: E501 line too long (131 > 130 characters)
Line 120:1: W293 blank line contains whitespace
Line 124:1: W293 blank line contains whitespace
Line 128:23: W291 trailing whitespace
Line 130:1: W293 blank line contains whitespace
Line 133:1: W293 blank line contains whitespace
Line 134:1: W293 blank line contains whitespace
Line 135:5: E303 too many blank lines (2)
Line 138:1: W293 blank line contains whitespace
Line 142:10: W291 trailing whitespace

Line 70:131: E501 line too long (134 > 130 characters)
Line 165:1: W293 blank line contains whitespace

Comment last updated at 2024-02-05 17:14:43 UTC

@07jasjeet
Copy link
Contributor Author

07jasjeet commented Jan 22, 2024

How should I go about the tests?

  • 3 tests are to be edited.
  • 2 new tests (to ensure "max" logic for input mbids and mbid array itself) for the target endpoint.


release_mbids = list(r["release_mbids"])

# Get release_group_mbids
Copy link
Member

@amCap1712 amCap1712 Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to support having both release mbids and release group mbids. If release mbids are specified use them if not try for release group mbids.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then depending on which entity is being used, pass the correct value (release or release-group) to

Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Using both releases and release groups like this will break some links in the SVGs so instead we simplify a few things and only support release or release groups at a time but not both.

@MonkeyDo MonkeyDo requested a review from amCap1712 March 11, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants