BB-680: Fun runner and Marathoner achievements are broken

[mr-loop-1]

Problem

BB680 - Fun runner and Marathoner achievements are broken

Solution

The ticket mentions about how consecutive days are not being considered. I fixed that issue by generating a date series and then seeing where user's dates are being broken and counting upto that.

It looks like the ticket and associated github link were outdated as when I went to the actual fork to do the change, the issues was already fixed. But since I already spent time on it and it is more semantic and maybe efficient this way, hence raising this PR.

Areas of Impact

achievements where streak is a factor.

[MonkeyDo]

Hi @mr-loop-1 !

You marked this PR as a draft, I was wondering if you wanted to discuss a way forward, if you had more things you wanted to add, or if I should test and review it.

Let me know :)

[mr-loop-1]

Hi @mr-loop-1 !

You marked this PR as a draft, I was wondering if you wanted to discuss a way forward, if you had more things you wanted to add, or if I should test and review it.

Let me know :)

Hi @MonkeyDo

This pr was supposed to be my base for GSoC proposal. I was a bit late to the party (basically on the last day) and chose this open issue. I solved the issue but ended up not submitting my application.
I don't remember how extensively I tested the code but you may now review it.

Also, written above

It looks like the ticket and associated github link were outdated as when I went to the actual fork to do the change, the issues was already fixed. But since I already spent time on it and it is more semantic and maybe efficient this way, hence raising this PR.