Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB-659: Add an author for a work from the WorkTable #830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

the-good-boy
Copy link
Contributor

Problem

In the WorkTable component which displays the works in an Edition, if the author of a work is not present, it is displayed as a "?". We should be able to directly add an author from here for this work (Similar to the Add ${entity} button which is displayed on the entity pages)

Solution

Now the "?" is clickable
EditionWorkTable

On clicking "?", it will take you to add Author page

AddAuthorLink

The editor will have the relationship with the work already attached
AuthorWithWorkRelationship

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I want to hold off a bit on this PR, as I think it may result in more duplicate entites.
The reason is it pushes users to create a new entity, rather than give them the option to create a new author or add a relationship to an existing author.
There is PR #804 that does attempt to do just that for Editions; I think we will end up going that route for Author-Work relationships as well.

title="Add Author"
variant="link"
>
?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the question mark is not very clear anymore as a clickable link. It was OK as a 'nothing to show here' but as a call to action I think something like this would work better, what do you think?

image

I'm using the same sort of button as the "Add work" button below for consistency, but with size="sm"

@MonkeyDo MonkeyDo changed the title [BB-569]: Add an author for a work from the WorkTable BB-569: Add an author for a work from the WorkTable Feb 27, 2023
@kellnerd
Copy link
Contributor

This is BB-659 not BB-569 😏

@MonkeyDo MonkeyDo changed the title BB-569: Add an author for a work from the WorkTable BB-659: Add an author for a work from the WorkTable Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants