Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BB-793): Improve the UX with the search field option entity #1075

Merged
merged 1 commit into from May 23, 2024

Conversation

MohamedAli00949
Copy link

@MohamedAli00949 MohamedAli00949 commented Mar 10, 2024

Hi there,
While searching for issues to contribute to Bookbrainz I found BB-793 for improving the UX of the add authors to collection form, I have found it a good start for a beginner such as me so I have started to work to know where is the problem and how to solve it.

Problem

The first time, I was trying to improve the search field element in authors to collection form such as the BB-793 issue, then I found that the search field element at more places such as add collaborators to the collection as you can see in the images below.
Screenshot from 2024-03-09 23-53-43
Screenshot from 2024-03-10 03-29-25

Solution

The first solution was to add a CSS class to handle the search field width to be suitable to screen width and provide a good UX, but I have found that this has happened but no effect we can notice.
The class Select is responsible for handling the width of the element, but it didn't work because the cloned element took its props from the parent of the wrapper select element without taking the wrapper select props as expected.

Screenshot from 2024-03-10 03-28-11
Screenshot from 2024-03-10 03-29-06

Areas of Impact

The PR effect on the common element EntitySearchFieldOption which is a part of the entity editor.

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this !

@MonkeyDo MonkeyDo merged commit db17d48 into metabrainz:master May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants