refactor simple react jsx to typescript #1066
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loading-spinner component is refactored to typescript
Refactor help page to typescript
Added React component Documentation
Refactor privacy page to use typescript
meziyum
changed the title
Refactor licensing page to typescript
Refactor develop page to typescript
Refactor contribute page to typescript
Refactor about page to typescript
MonkeyDo
requested changes
Mar 18, 2024
|
There is also a merge conflict that needs to be resolved, because I waited too long for the review (sorry!) |
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
…site into static-pages
meziyum
commented
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A lot of the codebase has been written in javascript lacking the type handlings in the code editor.
Solution
The codebase has been shifting towards typescript and thus to maintain consistency, existing components should be refactored to typescript.
Areas of Impact
src/client/components/loading-spinner.tsx
src/client/components/pages/faq.tsx
src/client/components/pages/help.tsx
src/client/components/pages/privacy.tsx
src/client/components/pages/licensing.tsx
src/client/components/pages/develop.tsx
src/client/components/pages/contribute.tsx
src/client/components/pages/about.tsx