-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sorting by Offset()
custom expression aggregation
#42737
Conversation
test/metabase/test/data.clj
Outdated
(ddl.i/format-name (tx/driver) (name a-name))) | ||
(ddl.i/format-name (tx/driver) (u/->snake_case_en (name a-name)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but I added this so switching between the lib.tu.macros
and mt
versions of stuff like id
or mbql-query
doesn't require you to switch between snake_case
and kebab-case
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@camsaul Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Fixes #42554