[MBQL lib] Hide :offset exprs in visibleColumns (and therefore filterableColumns etc.)
#42736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Offset expressions in the same stage cannot be used for ordering.
bshepherdson
force-pushed
the
mblib-offset-not-orderable
branch
from
26fc637
to
fe30595
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bshepherdson and the rest of your teammates on |
bshepherdson
changed the title
:offset for order-by:offset exprs in visibleColumns (and therefore filterableColumns etc.)
bshepherdson
merged commit 06b99db
into
offset-custom-expressions
125 of 130 checks passed
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offset expressions are what we might call "late" expressions - they only make sense at aggregation time, at the end of a query stage.
This change hides
:offsetexpressions invisibleColumnson a stage, which means they don't appear inexpressionableColumns,filterableColumnsororderableColumns. Like aggregations, they aren't "visible" within a stage, though they are returned from it. (:offsetexpressions appear inreturnColumns, of course.)Fixes #42725.