Fix overly frequent line series dots #42735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseSDevaney
added
no-backport
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff a3c3193...701d8e9.
|
|
JesseSDevaney
added
backport
EmmadUsmani
approved these changes
May 21, 2024
frontend/src/metabase/visualizations/echarts/cartesian/option/series.ts
Outdated
Show resolved
Hide resolved
|
@JesseSDevaney Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
May 21, 2024
* hide symbols for charts with too many of them * update loki * prevent series dots showing up after manually disabling another series * update loki snapshots * refactor conditional * update loki snapshots
metabase-bot bot
added a commit
that referenced
this pull request
May 21, 2024
* hide symbols for charts with too many of them * update loki * prevent series dots showing up after manually disabling another series * update loki snapshots * refactor conditional * update loki snapshots Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
oisincoveney
pushed a commit
that referenced
this pull request
May 22, 2024
* hide symbols for charts with too many of them * update loki * prevent series dots showing up after manually disabling another series * update loki snapshots * refactor conditional * update loki snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo Changes (before and after)
2024-05-15.19-48-13.mp4