Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow license tokens that start with airgap_ #42733

Merged
merged 1 commit into from
May 16, 2024

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented May 15, 2024

Accept license tokens with an airgap_ prefix, besides the already accepted 64-character long tokens.

This weakens the validation in the FE. Rigorous validation of tokens beginning with airgap_ occurs in the BE. See this Slack message.

Copy link
Contributor Author

rafpaf commented May 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafpaf and the rest of your teammates on Graphite Graphite

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 15, 2024
@rafpaf rafpaf changed the title Allow license tokens to begin with airgap_ Allow license tokens that start with airgap_ May 15, 2024
@rafpaf rafpaf force-pushed the allow-airgap-license-tokens branch from 1b1b504 to 92e29e2 Compare May 16, 2024 00:09
@rafpaf rafpaf marked this pull request as ready for review May 16, 2024 00:13
@graphite-app graphite-app bot added the no-backport Do not backport this PR to any branch label May 16, 2024
@graphite-app graphite-app bot requested a review from a team May 16, 2024 00:13
Copy link

Codenotify: Notifying subscribers in CODENOTIFY files for diff 4a6dfe4...92e29e2.

Notify File(s)
@ranquild frontend/src/metabase/setup/components/LicenseTokenStep/LicenseTokenForm.tsx
frontend/src/metabase/setup/components/LicenseTokenStep/constants.tsx
frontend/src/metabase/setup/components/LicenseTokenStep/constants.unit.spec.tsx
frontend/src/metabase/setup/tests/enterprise.unit.spec.tsx

Copy link

graphite-app bot commented May 16, 2024

Graphite Automations

"Notify author when CI fails" took an action on this PR • (05/16/24)

1 teammate was notified to this PR based on Raphael Krut-Landau's automation.

"Don't backport" took an action on this PR • (05/16/24)

1 label was added and 1 reviewer was added to this PR based on Raphael Krut-Landau's automation.

Copy link

replay-io bot commented May 16, 2024

Status Complete ↗︎
Commit 92e29e2
Results
⚠️ 3 Flaky
2506 Passed

@escherize escherize self-requested a review May 16, 2024 16:09
@escherize
Copy link
Contributor

escherize commented May 16, 2024

I double checked, and this has the expected behavior.

I was able to send the response, and the server was able to check it:

Screenshot 2024-05-16 at 10 26 18 AM

App started with:

MB_DB_CONNECTION_URI=postgres://bcm:password@localhost:5432/metabase_new
MB_EDITION=ee

@rafpaf rafpaf merged commit f225c92 into master May 16, 2024
196 of 208 checks passed
@rafpaf rafpaf deleted the allow-airgap-license-tokens branch May 16, 2024 21:58
Copy link

@rafpaf Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@rafpaf rafpaf added this to the 0.50 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants