Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow replacing a card with a metric on a dashboard #42732

Merged
merged 5 commits into from
May 16, 2024

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented May 15, 2024

Fixes #42598

Adds "metric" tab to QuestionPickerModal. Currently this is an opt-in feature because we don't want to allow to pick metrics in arbitrary places. Please note that this PR targets a somewhat outdated integration branch and we won't merge soon.

How to verify:

  • New -> Metric -> Orders -> Count -> Save
  • Open a dashboard with cards
  • Edit dashboard -> Hover over one of the dashcards -> Replace
  • Select the metric
  • It should properly replace the selected card
Screenshot 2024-05-15 at 18 54 07 Screenshot 2024-05-15 at 18 54 24 Screenshot 2024-05-15 at 18 54 31

@ranquild ranquild self-assigned this May 15, 2024
@ranquild ranquild requested a review from a team May 15, 2024 22:56
@metabase-bot metabase-bot bot added .Team/QueryingComponents visual Run Percy visual testing labels May 15, 2024
Copy link

github-actions bot commented May 15, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff f7aef16...4b53505.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/visualizations/DashCardPlaceholder.tsx

@ranquild ranquild marked this pull request as draft May 15, 2024 23:00
@ranquild ranquild removed the request for review from a team May 15, 2024 23:00
@ranquild ranquild changed the title Allow replacing a card with a metric on a dashboard [WIP] Allow replacing a card with a metric on a dashboard May 15, 2024
@ranquild ranquild marked this pull request as ready for review May 15, 2024 23:00
Copy link

replay-io bot commented May 15, 2024

Status In Progress ↗︎ 55 / 56
Commit 4b53505
Results
⚠️ 7 Flaky
2498 Passed

@ranquild ranquild requested review from iethree, kamilmielnik and a team May 16, 2024 02:23
@ranquild ranquild changed the title [WIP] Allow replacing a card with a metric on a dashboard Allow replacing a card with a metric on a dashboard May 16, 2024
@kamilmielnik kamilmielnik requested a review from a team May 16, 2024 07:20
@ranquild ranquild enabled auto-merge (squash) May 16, 2024 12:57
@ranquild ranquild merged commit 9ca3e93 into metrics-v2 May 16, 2024
112 checks passed
@ranquild ranquild deleted the 42598-replace-metric branch May 16, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Team/QueryingComponents visual Run Percy visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants