Correct Data Shape for Multi-Series Static Viz #42730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #41787 During the echarts migration, some backend tests needed fixing. In this process, the shape of data (eg. list of cards and their data results from execution) were altered. This was done to fix failing tests and renders for single series cards (all Questions and many dashcards), but didn't correctly handle a multi-series card. This conditionally adds back the expected shape. Perhaps in a follow on PR it's worth inspecting the implementation of the :javascript_visualization render method to clean it up. Probably worth putting some Malli schemas around it too to make it clearer what shape we need.
metabase-bot
bot
added
.Team/DashViz
|
We haven't made a 'unit' (perhaps more like a small integration test at this point) test for multi series dashcards yet. In most other cases, making sure a card (Question) renders properly is sufficient, but the multi series dashcards are a special case. It's probably useufl to have a test or two, and the dashcards test util should hopefully help future test writing a bit now too.
dpsutton
approved these changes
May 16, 2024
|
@adam-james-v Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #41787
During the echarts migration, some backend tests needed fixing. In this process, the shape of data (eg. list of cards and their data results from execution) were altered.
This was done to fix failing tests and renders for single series cards (all Questions and many dashcards), but didn't correctly handle a multi-series card.
This conditionally adds back the expected shape.
Perhaps in a follow on PR it's worth inspecting the implementation of the :javascript_visualization render method to clean it up. Probably worth putting some Malli schemas around it too to make it clearer what shape we need.