-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache config form to question sidebar #42729
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Notify author when CI fails" took an action on this PR • (05/15/24)1 teammate was notified to this PR based on Raphael Krut-Landau's automation. "Don't backport" took an action on this PR • (05/15/24)1 label was added and 1 reviewer was added to this PR based on Raphael Krut-Landau's automation. |
@@ -0,0 +1,55 @@ | |||
import type { Dispatch, SetStateAction } from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Only thing I see here is how we show the caching page. Rather than set up a specific sidebar, we are kinda hijacking the |
LGTM! Don't think there are massive pros/cons between the two approaches; even if one appears to be less convenient one day, it doesn't seem hard to tweak 👍 |
Thank you @kulyk 🙏🙏 |
7ae6923
to
9520b47
Compare
This PR adds a configuration form to the question sidebar. To launch it, visit a question, open the info sidebar (the "i" icon), and you'll see Caching policy, plus the name of the current caching policy for that question. Click the policy to open the form.
Closes #42731