Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache config form to question sidebar #42729

Merged
merged 4 commits into from
May 17, 2024
Merged

Add cache config form to question sidebar #42729

merged 4 commits into from
May 17, 2024

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented May 15, 2024

This PR adds a configuration form to the question sidebar. To launch it, visit a question, open the info sidebar (the "i" icon), and you'll see Caching policy, plus the name of the current caching policy for that question. Click the policy to open the form.

image.png

Closes #42731

Copy link
Contributor Author

rafpaf commented May 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafpaf and the rest of your teammates on Graphite Graphite

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 15, 2024
@rafpaf rafpaf marked this pull request as ready for review May 15, 2024 21:49
@graphite-app graphite-app bot requested a review from a team May 15, 2024 21:49
@graphite-app graphite-app bot added the no-backport Do not backport this PR to any branch label May 15, 2024
Copy link

graphite-app bot commented May 15, 2024

Graphite Automations

"Notify author when CI fails" took an action on this PR • (05/15/24)

1 teammate was notified to this PR based on Raphael Krut-Landau's automation.

"Don't backport" took an action on this PR • (05/15/24)

1 label was added and 1 reviewer was added to this PR based on Raphael Krut-Landau's automation.

@rafpaf rafpaf changed the title Squashed Add config form to question sidebar May 15, 2024
@@ -0,0 +1,55 @@
import type { Dispatch, SetStateAction } from "react";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

This is the form-launching component found in both the dashboard and question sidebars

Copy link

replay-io bot commented May 15, 2024

Status In Progress ↗︎ 59 / 62
Commit 704b177
Results
⚠️ 2 Flaky
2510 Passed

@rafpaf rafpaf changed the title Add config form to question sidebar Add cache config form to question sidebar May 15, 2024
@npfitz
Copy link
Contributor

npfitz commented May 16, 2024

Only thing I see here is how we show the caching page. Rather than set up a specific sidebar, we are kinda hijacking the <QuestionInfoSidebar/> component. I don't think it's a problem per say, but it does go against the pattern the other sidebars use. If we could get a thumbs up from the team that owns that code, then I think this is good to merge.

@kulyk
Copy link
Member

kulyk commented May 16, 2024

Only thing I see here is how we show the caching page. Rather than set up a specific sidebar, we are kinda hijacking the <QuestionInfoSidebar/> component. I don't think it's a problem per say, but it does go against the pattern the other sidebars use. If we could get a thumbs up from the team that owns that code, then I think this is good to merge.

LGTM! Don't think there are massive pros/cons between the two approaches; even if one appears to be less convenient one day, it doesn't seem hard to tweak 👍

Copy link
Contributor Author

rafpaf commented May 16, 2024

Thank you @kulyk 🙏🙏

@rafpaf rafpaf merged commit 6cfb3b5 into master May 17, 2024
108 checks passed
@rafpaf rafpaf deleted the perf/userland/qs branch May 17, 2024 03:33
@rafpaf rafpaf added this to the 0.50 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add caching policy form to question info sidebar
3 participants