Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hiding visualization for metrics in collections #42728

Merged
merged 1 commit into from
May 16, 2024
Merged

Allow hiding visualization for metrics in collections #42728

merged 1 commit into from
May 16, 2024

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented May 15, 2024 •
edited

Fixes #42618

How to verify:

  • Open a collection with metrics
  • Open the menu for a pinned metric and click "Don't show visualization"
  • Visualization should not be shown
  • It should be possible to select "Show visualization" and bring it back
Screenshot 2024-05-15 at 17 07 57 Screenshot 2024-05-15 at 17 08 00 Screenshot 2024-05-15 at 17 08 03

@ranquild ranquild self-assigned this May 15, 2024
@ranquild ranquild requested a review from a team May 15, 2024 21:06
@replay-io replay.io
Copy link

replay-io bot commented May 15, 2024 •
edited

Status In Progress ↗︎ 53 / 54
Commit 18fa5f1
Results
⚠️ 6 Flaky
✅ 2477 Passed

@ranquild ranquild merged commit 74f9c45 into metrics-v2 May 16, 2024
115 of 124 checks passed
@ranquild ranquild deleted the 42618-metrics-hide-viz branch May 16, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilmielnik kamilmielnik kamilmielnik approved these changes

Assignees

@ranquild ranquild

Labels
.Team/QueryingComponents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ranquild @kamilmielnik